Remove code to check failure store #2553
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change reverts 1fbc6f7, after the feature changed in a breaking way in 8.18. We will wait till the feature is GA and documented.
Collaborator
💚 Build Succeeded
History
cc @jsoriano |
kpollich
approved these changes
Apr 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The failure store was added in technical preview in 8.15, and it is not documented. We started using it after #1973.
It is still under development and its APIs changed in a breaking way in 8.18. From 8.18 this feature is not working in elastic-package, as it cannot detect if the feature is available. Our tests for this feature are failing.
We would need to change three things:
I tried to adapt elastic-package to the new APIs in #2547, but didn't manage to solve the third part, searching in the failure store.
As the feature is still in technical preview, it is not documented, and there might be more changes in the future, I think it can be difficult to reliably maintain code based on this. So I think we should drop its use in elastic-package by now.
This change effectively reverts most of 1fbc6f7. We will wait till the feature is better documented, and GA or closer to GA.
Related issues